Revendor installer: OpenStack >=1 MachineSet#2436
Conversation
openshift-ci
bot
added
the
approved
We got unlucky when we revendored installer and picked up OCPBUGS-17064, which causes the MachineSets generator to produce zero MachineSets when the input specifies zero Replicas, as it does when we're autoscaling. Revendor to the (current) tip of the 4.14 branch to pick up the fix. Adjust machinepool controller accordingly. HIVE-2590
2uasimojo
force-pushed
the
HIVE-2590/revendor-openstack-min-1-mset
branch
from
b7ec274 to
a4b3fda
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mce-2.5 #2436 +/- ##
========================================
Coverage 57.92% 57.92%
========================================
Files 186 186
Lines 26079 26080 +1
========================================
+ Hits 15105 15106 +1
Misses 9711 9711
Partials 1263 1263
|
|
/override ci/prow/security #2387 (which might possibly work now that we've revendored installer here??) |
|
/override "Red Hat Konflux / hive-mce-25-on-pull-request" |
|
@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@2uasimojo: Overrode contexts on behalf of 2uasimojo: Red Hat Konflux / hive-mce-25-on-pull-request DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @dlom |
|
/cherry-pick mce-2.4 I have a feeling we'll conflict in the vendor dirs, but it's worth a try :) |
|
@2uasimojo: once the present PR merges, I will cherry-pick it on top of mce-2.4 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm Vendoring the entire installer sucks and I wish there was a better way :/ |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo, dlom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@2uasimojo: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@2uasimojo: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked. Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Manually applied to mce-2.4 via #2438. |
3 participants
We got unlucky when we revendored installer and picked up OCPBUGS-17064, which causes the MachineSets generator to produce zero MachineSets when the input specifies zero Replicas, as it does when we're autoscaling.
Revendor to the (current) tip of the 4.14 branch to pick up the fix.
HIVE-2590